Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mismatched names #320

Merged
merged 6 commits into from
Aug 16, 2021
Merged

Add mismatched names #320

merged 6 commits into from
Aug 16, 2021

Conversation

SCasanova
Copy link
Contributor

Added
Patrick/Pat Mahomes
Josh/Joshua Jacobs
Maurice Jones-Drew/Drew

@SCasanova
Update mismatches.csv
d359ab2
@SCasanova
Update mismatches.csv
22e5225 
Added Patrick/Pat Mahomes, Josh/Joshua Jacobs and Maurice Jones-Drew/Drew
@tanho63 tanho63 changed the base branch from main to dev August 13, 2021 01:37
@tanho63
Copy link
Member

tanho63 commented Aug 13, 2021 •
edited
Loading

Hiya! Can you:

  • remove the space before each name
  • run usedata_namemapping.R in data-raw
  • commit and push the resulting data folder and data-raw folder?

@tanho63 tanho63 mentioned this pull request Aug 13, 2021
Closed
@tanho63 tanho63 enabled auto-merge August 16, 2021 17:39
@tanho63 tanho63 disabled auto-merge August 16, 2021 17:39
@tanho63 tanho63 enabled auto-merge (squash) August 16, 2021 17:39
@tanho63
Copy link
Member

tanho63 commented Aug 16, 2021

Looks good to me! Thanks for the contrib 👍

@tanho63 tanho63 merged commit e65fb2f into ffverse:dev Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCasanova @tanho63